LibWeb: Update Element class list is when class attribute is removed

tcl3 · Jul 24, 2024 · f2ebd0e · f2ebd0e
1 parent 3b7534b
commit f2ebd0e
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/Tests/LibWeb/Text/expected/DOM/Element-classList.txt b/Tests/LibWeb/Text/expected/DOM/Element-classList.txt
@@ -0,0 +1,3 @@
+ element.classList initial value: ""
+element.classList after setting classList to "a": "a"
+element.classList after setting className to "": ""
diff --git a/Tests/LibWeb/Text/input/DOM/Element-classList.html b/Tests/LibWeb/Text/input/DOM/Element-classList.html
@@ -0,0 +1,13 @@
+<!DOCTYPE html>
+<script src="../include.js"></script>
+<script>
+    test(() => {
+        const element = document.createElement("div");
+        println(`element.classList initial value: "${element.classList.toString()}"`);
+        element.classList = "a";
+        println(`element.classList after setting classList to "a": "${element.classList.toString()}"`);
+        element.className = "";
+        println(`element.classList after setting className to "": "${element.classList.toString()}"`);
+    });
+</script>
+</html>
diff --git a/Userland/Libraries/LibWeb/DOM/Element.cpp b/Userland/Libraries/LibWeb/DOM/Element.cpp
@@ -480,9 +480,9 @@ void Element::attribute_changed(FlyString const& name, Optional<String> const&,
             for (auto& new_class : new_classes) {
                 m_classes.unchecked_append(FlyString::from_utf8(new_class).release_value_but_fixme_should_propagate_errors());
             }
-            if (m_class_list)
-                m_class_list->associated_attribute_changed(value_or_empty);
         }
+        if (m_class_list)
+            m_class_list->associated_attribute_changed(value_or_empty);
     } else if (name == HTML::AttributeNames::style) {
         if (!value.has_value()) {
             if (m_inline_style) {