Add tests for abrupt completion of the then call in NewPromiseResolveThenableJob - #5078
Open
alii wants to merge 3 commits into
Open
Add tests for abrupt completion of the then call in NewPromiseResolveThenableJob#5078alii wants to merge 3 commits into
alii wants to merge 3 commits into
Conversation
…ThenableJob There's no coverage for NewPromiseResolveThenableJob step 1.c (reject the promise when the then call throws). The existing thenable tests only poison the then getter, use a custom then that resolves, or throw after resolving. The two species tests also catch a real engine bug: JSC never settles the promise when constructor[Symbol.species] throws inside the job (https://bugs.webkit.org/show_bug.cgi?id=318399, fix in WebKit/WebKit#68487). They fail on every current JSC and pass on V8 and on JSC trunk with that fix. The other two pass everywhere and just fill the coverage gap.
alii
force-pushed
the
promise-thenable-job-abrupt-then
branch
from
July 2, 2026 07:35
d48f118 to
0f85eb6
Compare
Contributor
|
Thanks! You may want to consider using the |
Author
|
Thank you! Updated to use them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no coverage for NewPromiseResolveThenableJob step 1.c (reject the promise when the then call throws). The existing thenable tests only poison the then getter, use a custom then that resolves, or throw after resolving.
The two species tests also catch a real engine bug: JSC never settles the promise when constructor[Symbol.species] throws inside the job (https://bugs.webkit.org/show_bug.cgi?id=318399, fix in WebKit/WebKit#68487). They fail on every current JSC and pass on V8 and on JSC trunk with that fix. The other two pass everywhere and just fill the coverage gap.