Fixup assertion message in AsyncGenerator.p.return with broken promises #4486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jack-Works
reviewed
May 13, 2025
| @@ -53,7 +53,7 @@ it.return(brokenPromise) | |||
| throw new Test262Error("Expected rejection"); | |||
| }, | |||
| err => { | |||
| assert(unblocked, false, 'return should be rejected before generator is resumed'); | |||
| assert(unblocked, 'return should be rejected when the generator is completed'); | |||
There was a problem hiding this comment.
Suggested change
| assert(unblocked, 'return should be rejected when the generator is completed'); | |
| assert(unblocked, 'return should be rejected after the generator is resumed'); |
There was a problem hiding this comment.
This is describing the state of the async generator, which is completed though. See the info section:
AsyncGenerator.prototype.return ( value )
...
8. If state is either suspendedStart or completed, then
a. Set generator.[[AsyncGeneratorState]] to awaiting-return.
b. Perform ! AsyncGeneratorAwaitReturn(generator).
There was a problem hiding this comment.
@legendecas In this test, the state of the generator when .return is called is ~executing~, not ~completed~, because at the time .return is called the generator is paused at await blocking. So the quoted step doesn't apply.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/tc39/test262/pull/3472/files#r2085898854