Skip to content

Add coverage for some implementation bugs in Array and TypedArray methods #4477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add coverage for some implementation bugs in Array and TypedArray methods #4477

wants to merge 8 commits into from

Conversation

anba
Copy link
Contributor

@anba anba commented May 12, 2025

Coverage for some implementation bugs in JSC, V8, and SpiderMonkey.

anba added 7 commits May 12, 2025 15:57
@anba
Add coverage for throw completions in (Typed)Array.prototype.with
66a443a 
SpiderMonkey doesn't handle this correctly for `Array.prototype.with`.
@anba
Add coverage for odd string lengths in Uint8Array.prototype.setFromHex
e09aaeb 
V8 doesn't handle this correctly for zero length typed arrays.
@anba
Add coverage for converting negative fractional index to zero in (Typ…
bd47071 
…ed)Array.prototype.with

JSC doesn't handle this correctly for `TypedArray.prototype.with`.
@anba
Add coverage for negative indices with resizable typed arrays to TA.p…
5a4febf 
…rototype.with

V8 doesn't handle this case correctly.
@anba
Add coverage for negative indices with resizable typed arrays
bb7e7bb 
SpiderMonkey doesn't handle this case correctly.
@anba
Add coverage for species constructor returning typed array with same …
a1d5d2e 
…backing buffer

JSC doesn't handle this case correctly.
@anba
Add coverage for byteOffset with detached buffer in TypedArray.protot…
fc627a5 
…ype.subarray

JSC doesn't handle this case correctly.
@anba anba requested a review from a team as a code owner May 12, 2025 14:04
ljharb added a commit to es-shims/Array.prototype.with that referenced this pull request May 12, 2025
@ljharb
[Tests] add coverage
3d5d622 
From tc39/test262#4477
ljharb
ljharb approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not review the TypedArray tests. verified the with and setFromHex tests against my polyfills

ljharb added a commit to es-shims/es-arraybuffer-base64 that referenced this pull request May 12, 2025
@ljharb
[Tests] add coverage
122a4b4 
From tc39/test262#4477
lando-prod-mozilla bot pushed a commit to mozilla-firefox/firefox that referenced this pull request May 13, 2025
@anba
Bug 1965844 - Part 3: Don't overwrite a pending exception in Array.pr…
b1bb7ec 
…ototype.with. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248928
lando-prod-mozilla bot pushed a commit to mozilla-firefox/firefox that referenced this pull request May 13, 2025
@anba
Bug 1965844 - Part 4: Correctly update search index for resized typed…
b8c4d84 
… array in lastIndexOf. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248929
lando-prod-mozilla bot pushed a commit to mozilla-firefox/firefox that referenced this pull request May 13, 2025
@anba
Bug 1965844 - Part 3: Don't overwrite a pending exception in Array.pr…
979a6c8 
…ototype.with. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248928
lando-prod-mozilla bot pushed a commit to mozilla-firefox/firefox that referenced this pull request May 13, 2025
@anba
Bug 1965844 - Part 4: Correctly update search index for resized typed…
adee045 
… array in lastIndexOf. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248929
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request May 13, 2025
@anba
Bug 1965844 - Part 3: Don't overwrite a pending exception in Array.pr…
eb5bcf5 
…ototype.with. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248928
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request May 13, 2025
@anba
Bug 1965844 - Part 4: Correctly update search index for resized typed…
515b760 
… array in lastIndexOf. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248929
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request May 13, 2025
@anba
Bug 1965844 - Part 3: Don't overwrite a pending exception in Array.pr…
630e1c4 
…ototype.with. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248928
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request May 13, 2025
@anba
Bug 1965844 - Part 4: Correctly update search index for resized typed…
121f364 
… array in lastIndexOf. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248929
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request May 14, 2025
@marco-c
Bug 1965844 - Part 3: Don't overwrite a pending exception in Array.pr…
edd8ba8 
…ototype.with. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248928

UltraBlame original commit: 1c03eb73265d4c6d57cff099c3f00aaced99075f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request May 14, 2025
@marco-c
Bug 1965844 - Part 4: Correctly update search index for resized typed…
bcdb903 
… array in lastIndexOf. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248929

UltraBlame original commit: 192b5d74f9ca4a7594142bf8fd789e2d5ab20b9c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request May 14, 2025
@marco-c
Bug 1965844 - Part 3: Don't overwrite a pending exception in Array.pr…
a7c1e30 
…ototype.with. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248928

UltraBlame original commit: 4c54c405baf8acea20927e66c1dc6e9b88c25b25
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request May 14, 2025
@marco-c
Bug 1965844 - Part 4: Correctly update search index for resized typed…
e6a7652 
… array in lastIndexOf. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248929

UltraBlame original commit: a7c3286c781fa3d67f2b75540b9be2c476e523a0
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request May 14, 2025
@marco-c
Bug 1965844 - Part 3: Don't overwrite a pending exception in Array.pr…
4f22f4e 
…ototype.with. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248928

UltraBlame original commit: 1c03eb73265d4c6d57cff099c3f00aaced99075f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request May 14, 2025
@marco-c
Bug 1965844 - Part 4: Correctly update search index for resized typed…
3d99ff6 
… array in lastIndexOf. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248929

UltraBlame original commit: 192b5d74f9ca4a7594142bf8fd789e2d5ab20b9c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request May 14, 2025
@marco-c
Bug 1965844 - Part 3: Don't overwrite a pending exception in Array.pr…
93b9481 
…ototype.with. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248928

UltraBlame original commit: 4c54c405baf8acea20927e66c1dc6e9b88c25b25
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request May 14, 2025
@marco-c
Bug 1965844 - Part 4: Correctly update search index for resized typed…
be8e222 
… array in lastIndexOf. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248929

UltraBlame original commit: a7c3286c781fa3d67f2b75540b9be2c476e523a0
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request May 14, 2025
@marco-c
Bug 1965844 - Part 3: Don't overwrite a pending exception in Array.pr…
371a6c9 
…ototype.with. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248928

UltraBlame original commit: 1c03eb73265d4c6d57cff099c3f00aaced99075f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request May 14, 2025
@marco-c
Bug 1965844 - Part 4: Correctly update search index for resized typed…
75fe12b 
… array in lastIndexOf. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248929

UltraBlame original commit: 192b5d74f9ca4a7594142bf8fd789e2d5ab20b9c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request May 14, 2025
@marco-c
Bug 1965844 - Part 3: Don't overwrite a pending exception in Array.pr…
1ab214d 
…ototype.with. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248928

UltraBlame original commit: 4c54c405baf8acea20927e66c1dc6e9b88c25b25
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request May 14, 2025
@marco-c
Bug 1965844 - Part 4: Correctly update search index for resized typed…
0ec3f4c 
… array in lastIndexOf. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248929

UltraBlame original commit: a7c3286c781fa3d67f2b75540b9be2c476e523a0
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request May 15, 2025
@anba
Bug 1965844 - Part 3: Don't overwrite a pending exception in Array.pr…
3ded4c3 
…ototype.with. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248928
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request May 15, 2025
@anba
Bug 1965844 - Part 4: Correctly update search index for resized typed…
2d5c3c8 
… array in lastIndexOf. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248929
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request May 15, 2025
@anba
Bug 1965844 - Part 3: Don't overwrite a pending exception in Array.pr…
dcd49f4 
…ototype.with. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248928
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request May 15, 2025
@anba
Bug 1965844 - Part 4: Correctly update search index for resized typed…
a1d1fb6 
… array in lastIndexOf. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248929
gibson042
gibson042 approved these changes May 15, 2025
View reviewed changes
@anba @gibson042
Update test/built-ins/TypedArray/prototype/slice/speciesctor-return-s…
34f0eb1 
…ame-buffer-with-offset.js

Co-authored-by: Richard Gibson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@gibson042 gibson042 gibson042 approved these changes

Assignees
No one assigned
Labels
awaiting author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anba @ljharb @gibson042 @Ms2ger @ptomato