Test a module depending on a non-root node of an async cycle #4465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See tc39/ecma262#3584 (comment).
This case was not previously covered by any test. I tested it by updating engine262's implementation to not "Set requiredModule to requiredModule.[[CycleRoot]]", and all existing test262 tests were still passing.
Usually the
info
of a test only contains spec text, but given that this algorithm is run 4 times by this PR and that the control flow is not trivial I wrote a more detailed explanation.