Skip to content

Test a module depending on a non-root node of an async cycle #4465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented May 2, 2025

See tc39/ecma262#3584 (comment).

This case was not previously covered by any test. I tested it by updating engine262's implementation to not "Set requiredModule to requiredModule.[[CycleRoot]]", and all existing test262 tests were still passing.

Usually the info of a test only contains spec text, but given that this algorithm is run 4 times by this PR and that the control flow is not trivial I wrote a more detailed explanation.

@nicolo-ribaudo nicolo-ribaudo requested a review from a team as a code owner May 2, 2025 09:41
@nicolo-ribaudo nicolo-ribaudo changed the title Test a module depending on a non-root node of an asyn cycle Test a module depending on a non-root node of an async cycle May 2, 2025
@nicolo-ribaudo nicolo-ribaudo force-pushed the add-test-for-module-depending-on-non-root-of-async-cycle branch 3 times, most recently from bfc4c33 to 963385e Compare May 2, 2025 09:47
@nicolo-ribaudo
Copy link
Member Author

Everybody is passing this new test except for XS, cc @phoddie

@nicolo-ribaudo nicolo-ribaudo force-pushed the add-test-for-module-depending-on-non-root-of-async-cycle branch from 963385e to fbd7f63 Compare May 6, 2025 13:46
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I completely understood this test, so a review from someone else would be helpful. But it looks correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants