Start cleaning up staging/sm tests #4463
Conversation
| @@ -10,7 +10,7 @@ function assertFalse(a) { assertEq(a, false) } | |||
| function assertTrue(a) { assertEq(a, true) } | |||
| function assertNotEq(found, not_expected) { assertEq(Object.is(found, not_expected), false) } | |||
| function assertIteratorResult(result, value, done) { | |||
| assertDeepEq(result.value, value); | |||
| assert.deepEqual(result.value, value); | |||
There was a problem hiding this comment.
@Ms2ger Does your importation script need to be updated to make this replacement as well?
test/staging/sm/strict/15.4.5.1.js
Outdated
| try | ||
| { | ||
| strict1(out); | ||
| throw "no error"; | ||
| } | ||
| catch (e) | ||
| { | ||
| assert.sameValue(e instanceof TypeError, true, "expected TypeError, got " + e); | ||
| } | ||
| assert.sameValue(deepEqual(out.array, [1, 2, 3]), true); | ||
|
|
||
| // Internally, SpiderMonkey has two representations for arrays: | ||
| // fast-but-inflexible, and slow-but-flexible. Adding a non-index property | ||
| // to an array turns it into the latter. We should test on both kinds. | ||
| function addx(obj) { | ||
| obj.x = 5; | ||
| return obj; | ||
| } | ||
|
|
||
| function nonStrict2(out) | ||
| { | ||
| var a = out.array = addx(arr()); | ||
| a.length = 2; | ||
| } | ||
|
|
||
| function strict2(out) | ||
| { | ||
| "use strict"; | ||
| var a = out.array = addx(arr()); | ||
| a.length = 2; | ||
| } | ||
|
|
||
| out.array = null; | ||
| nonStrict2(out); | ||
| assert.sameValue(deepEqual(out.array, addx([1, 2, 3])), true); | ||
|
|
||
| out.array = null; | ||
| try | ||
| { | ||
| strict2(out); | ||
| throw "no error"; | ||
| } | ||
| catch (e) | ||
| { | ||
| assert.sameValue(e instanceof TypeError, true, "expected TypeError, got " + e); | ||
| } | ||
| assert.sameValue(deepEqual(out.array, addx([1, 2, 3])), true); | ||
| assert.throws(TypeError, function() { | ||
| strict1(out); | ||
| }); |
There was a problem hiding this comment.
I guess maybe in the interest of max coverage of implementation strategies, we shouldn't necessarily remove this just because SpiderMonkey updated their implementation details? Making an array slow when adding a non-index property seems like a choice that other implementations might make.
There was a problem hiding this comment.
The file tests that modifying length fails for an array with a non-configurable array element. If we want to have a test to cover that arrays support non-index properties, we shouldn't use this file for that. (And we probably already have coverage that arrays support non-index properties.)
The test itself was added in https://bugzilla.mozilla.org/show_bug.cgi?id=537873. And the "slow array" part became obsolete twelve years ago in https://bugzilla.mozilla.org/show_bug.cgi?id=827490.
There was a problem hiding this comment.
Consider keeping this while just removing the enableGeckoProfiling stubs? Or is there already explicitly coverage for this in the main tree?
There was a problem hiding this comment.
The test boils down to:
function* gen() {
var x = yield 'hi';
yield x;
yield 'bye';
}
for (var unused of [ true, false ]) {
g = gen();
assert.sameValue(g.next().value, 'hi');
assert.sameValue(g.next('gurgitating...').value, 'gurgitating...');
for (var x of g)
assert.sameValue(x, 'bye');
}which is covered through various tests in "built-ins/GeneratorPrototype/next" and "language/statements/for-of".
| @@ -22,10 +22,10 @@ function TestGeneratorObject() { | |||
|
|
|||
| var iter = g(); | |||
| assert.sameValue(Object.getPrototypeOf(iter), g.prototype); | |||
| assertTrue(iter instanceof g); | |||
| assert.sameValue(iter instanceof g, true); | |||
There was a problem hiding this comment.
I'd prefer assert(iter instanceof g); or better, assert(iter instanceof g, "insert appropriate debugging message") for these kinds of assertions.
There was a problem hiding this comment.
#4371 (comment) requested changing assert(expr) to assert.sameValue(expr, true).
There was a problem hiding this comment.
Oh, too bad. Well, let's keep it as is then, I don't want to conflict with others' comments.
…in-first-expression.js
…ntains-unicode-escape.js and fix a test bug
Changes:
noStrictflag where possible.I've also identified a couple of tests which should be removed from test262, because they test non-standard behaviour:
Function.caller.Date.parsewith non-standard inputs.Mathfunctions are.disassembleortimeout.In a follow-up PR I can remove these tests, too.