Conversation
…-configurable and non-writable
1292d82 to
9791a9a
Compare
erights
approved these changes
Oct 4, 2024
Collaborator
erights
left a comment
There was a problem hiding this comment.
I'm going to approve it without reading the .emu text. Once it is rendered, I'll read that and give any needed feedback then.
Collaborator
|
Read the render, thanks. Lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...allowing such TypedArrays to be frozen.
GFM rendering of this PR's diff from upstream ECMA-262:
removals, additions10.4.5 TypedArray Exotic Objects
10.4.5.1 [[GetOwnProperty]] ( P )
The [[GetOwnProperty]] internal method of a TypedArray O takes argument P (a property key) and returns a normal completion containing either a Property Descriptor or undefined. It performs the following steps when called:
truemutable, [[Enumerable]]: true, [[Configurable]]:truemutable }.10.4.5.3 [[DefineOwnProperty]] ( P, Desc )
The [[DefineOwnProperty]] internal method of a TypedArray O takes arguments P (a property key) and Desc (a Property Descriptor) and returns either a normal completion containing a Boolean or a throw completion. It performs the following steps when called:
falsenot mutable, return false.falsenot mutable, return false.10.4.5.5 [[Set]] ( P, V, Receiver )
The [[Set]] internal method of a TypedArray O takes arguments P (a property key), V (an ECMAScript language value), and Receiver (an ECMAScript language value) and returns either a normal completion containing a Boolean or a throw completion. It performs the following steps when called: