Meta: always use snapshot upload code from main #3698
Merged
+144
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Oct 1, 2025
gibson042
approved these changes
Oct 2, 2025
Member
There was a problem hiding this comment.
Copying the scripts from main is a nice approach. We should also propagate it to template-for-proposals.
To make this easier I've also inlined the code for the warnings into the script which inserts them, instead of reading from disk.
I'm ambivalent about this change, which makes editing less pleasant but is overall fine.
bakkot
added
the
ready to merge
ljharb
force-pushed
the
pr-previews-scripts-from-main
branch
from
b57f917 to
1c55ca1
Compare
ljharb
approved these changes
Nov 4, 2025
Member
|
I believe this failure is by design - it's intending to break any workflows from prior to this PR - so I'll go ahead and land it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make this easier I've also inlined the code for the warnings into the script which inserts them, instead of reading from disk.