Conversation
michaelficarra
added
normative change
Contributor
Author
|
@michaelficarra This doesn't have any effect on behaviour of source text evaluation. It's strictly only a reordering of a few lines. |
linusg
added
editorial change
and removed
normative change
michaelficarra
approved these changes
May 15, 2025
Member
michaelficarra
left a comment
michaelficarra
left a comment
There was a problem hiding this comment.
Ah I see, this is relying on the fact that there's no call site for iterationKind of ~enumerate~ and iteratorKind of ~async~. This could probably be stated explicitly somewhere.
Contributor
Author
I can add asserts in the |
Member
|
@aapoalas I had something else in mind #3475 (comment) |
michaelficarra
force-pushed
the
editorial/for-in-of-body-iterator-close-unification
branch
from
9816e74 to
9d2b0a9
Compare
bakkot
approved these changes
Sep 29, 2025
bakkot
added
the
ready to merge
…ult handling in ForIn/OfBodyEvaluation (tc39#3595)
ljharb
force-pushed
the
editorial/for-in-of-body-iterator-close-unification
branch
from
9d2b0a9 to
be305fc
Compare
Jack-Works
added a commit
to engine262/engine262
that referenced
this pull request
Oct 6, 2025
…ult handling in ForIn/OfBodyEvaluation tc39/ecma262#3595
Jack-Works
added a commit
to engine262/engine262
that referenced
this pull request
Oct 23, 2025
…ult handling in ForIn/OfBodyEvaluation tc39/ecma262#3595
jhnaldo
pushed a commit
to ku-plrg/ecma262
that referenced
this pull request
Oct 31, 2025
…ult handling in ForIn/OfBodyEvaluation (tc39#3595)
Closed
jhnaldo
pushed a commit
to ku-plrg/ecma262
that referenced
this pull request
Oct 31, 2025
…ult handling in ForIn/OfBodyEvaluation (tc39#3595)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A personal favourite of mine: the order of checking/comparing
iterationKindanditeratorKindis different between two otherwise nearly identical blocks handling abrupt completions (exceptions) in the loop header binding, and handling non-loop-continuing results of the body evaluation.The difference makes the two blocks really hard to compare, even though they're 100% the same except for the
UpdateEmptycall.