Editorial: TypedArrayCreateSameType take length as parameter#3570
Merged
Editorial: TypedArrayCreateSameType take length as parameter#3570
Conversation
aapoalas
commented
Apr 20, 2025
aapoalas
commented
Apr 20, 2025
ljharb
changed the title
syg
approved these changes
Apr 23, 2025
bakkot
reviewed
Apr 24, 2025
bakkot
reviewed
Apr 24, 2025
bakkot
approved these changes
Apr 24, 2025
Member
bakkot
left a comment
bakkot
left a comment
There was a problem hiding this comment.
lgtm other than comment (which we can address when landing if you don't get to it)
Contributor
Author
Sorry this took a while, merged the comment. Thanks! <3 |
michaelficarra
added
the
ready to merge
ljharb
force-pushed
the
feat/typed-array-create-same-type-length
branch
from
00f75c7 to
3864092
Compare
Jack-Works
added a commit
to engine262/engine262
that referenced
this pull request
Aug 31, 2025
Jack-Works
added a commit
to engine262/engine262
that referenced
this pull request
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method is only called with an explicit length but because it can theoretically take any arguments list, the call to TypedArray construction could trigger user code: this is not really possible in the current spec.