-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): implement tags/list endpoint #86
base: master
Are you sure you want to change the base?
Conversation
Using a local clone of
|
Hey, thanks for this PR! Seems like a useful feature :-) Before doing an in-depth review, I have a couple of remarks:
|
Hi, thanks for the feedback
When trying to build with some git tag (19.09):
|
When a git source is used branch names are exposed in the tags list. For other source types, only "latest" is exposed. Fixes: tazjin#85
Ok I get why building git tags doesn't work. In the if commitRegex.MatchString(tag) {
args["rev"] = tag
} else {
args["ref"] = tag
} And I found in the manual for So that means that |
Hm, interesting, thanks! Lets spin the tag issue out into a separate problem for now (#89).
Yeah, currently this happens as part of the build. In order for the functionality implemented here to work for remote repos the fetching needs to be separate. I believe the call to As for the dependency on |
I've removed the dependency to |
When a git source is used branch names are exposed in the tags list.
For other source types, only "latest" is exposed.
Fixes: #85