-
Notifications
You must be signed in to change notification settings - Fork 1
Add Android CI #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @marcprux, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the project's continuous integration coverage by adding a dedicated workflow for Android. It ensures that test cases are automatically executed on an Android Emulator, leveraging the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces Android CI, and the changes in README.md add a status badge for it. The change is straightforward, and I've provided a suggestion to improve the consistency of the badge's alt text.
| | Platform | Status | | ||
| | -------- | ------ | | ||
| | 🐧 Linux | [](https://github.com/tayloraswift/d/actions/workflows/Tests.yml) | | ||
| | 🤖 Android | [](https://github.com/tayloraswift/d/actions/workflows/android.yml) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with other mobile platforms in this table (like iOS and tvOS), it would be better to use 'Android' as the alt text for the badge instead of 'Tests'.
| | 🤖 Android | [](https://github.com/tayloraswift/d/actions/workflows/android.yml) | | |
| | 🤖 Android | [](https://github.com/tayloraswift/d/actions/workflows/android.yml) | |
|
ty! |
This PR adds CI for Android, which runs the test cases against the Android Emulator using swift-android-action. A successful run can be seen here.