Skip to content

Fix unsafe realloc #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jserv wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix unsafe realloc #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion coffsyrup.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,12 @@ int main(int argc, char **argv)
errx(EXIT_FAILURE, "The static symbol %s did not have a section number.", symname);
}

pmkrelocs = realloc(pmkrelocs, ++nmkrelocs * sizeof(*pmkrelocs));
void *tmp = realloc(pmkrelocs, (nmkrelocs + 1) * sizeof(*pmkrelocs));
if (!tmp) {
err(EXIT_FAILURE, "Failed to allocate relocation entry");
}
pmkrelocs = tmp;
nmkrelocs++;
pmkrelocs[nmkrelocs - 1].e_value = symtab[i].e_value;
pmkrelocs[nmkrelocs - 1].r_symndx = i;

Expand Down