Open
Conversation
Contributor
jserv
commented
Feb 20, 2026
- display.c: stpstatus[64] overflow via strcat chain; enlarged to 256, replaced with bounded snprintf
- main.c: lotargv alloca undercount; first-pass counted 1 per option but pass-through options with args need 2 slots; count += 2 per iteration
- showme.c: clear_showme writes past MAX_SHOWME arrays; add count guard
- coffsyrup.c: Relocation boundary check allows 4-byte write past section buffer; account for sizeof(uint32_t) in range check Symbol index off-by-one; change > to >= for f_nsyms bound
- display.c: stpstatus[64] overflow via strcat chain; enlarged to 256, replaced with bounded snprintf - main.c: lotargv alloca undercount; first-pass counted 1 per option but pass-through options with args need 2 slots; count += 2 per iteration - showme.c: clear_showme writes past MAX_SHOWME arrays; add count guard - coffsyrup.c: Relocation boundary check allows 4-byte write past section buffer; account for sizeof(uint32_t) in range check Symbol index off-by-one; change > to >= for f_nsyms bound
Owner
|
Hmm, I think you're right about the argument parsing - nice catch! The stpstatus patch doesn't look correct, I think it's uninitialized when the first |
Owner
|
No, I'm wrong - I think it is always initialized, hmm - oops, maybe you're right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.