Open
Conversation
F_SETFL was broken: used the translated command constant instead of the caller's flags from arg, and passed &linuxflags (a pointer) where fcntl expects an int. This also fixes several related issues in the same function: - F_GETFL: errno set unconditionally, leaking stale values on success - F_GETLK: input lock region not populated before kernel query - F_DUPFD: returned 0 instead of the new file descriptor - cmd table indexed without bounds check (OOB on bad input) - unmapped table entries silently mapped to F_DUPFD (index 0) - F_SETLKW mapped in table but missing from switch (process abort) - F_GETFD/F_SETFD mapped in table but missing from switch - default case called err() killing the process instead of EINVAL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F_SETFL was broken: used the translated command constant instead of the caller's flags from arg, and passed &linuxflags (a pointer) where fcntl expects an int.
This also fixes several related issues in the same function: