fix(macos-sign): import the signing certificate as an explicit pkcs12 (fix: #15843) - #15844
Open
lazerg wants to merge 1 commit into
Open
fix(macos-sign): import the signing certificate as an explicit pkcs12 (fix: #15843)#15844lazerg wants to merge 1 commit into
lazerg wants to merge 1 commit into
Conversation
lazerg
force-pushed
the
fix/issue-15843-p12-import-format
branch
from
August 8, 2026 11:54
df89909 to
13d288d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
security importwas left to guess the file format. On macOS 26 that guess goes wrong for p12 files using modern PBES2/AES encryption and the import dies withMAC verification failed during PKCS12 import (wrong password?), even when the password is correct.I reproduced it on macOS 26.6.1 with a p12 encrypted using AES-256-CBC with a SHA-256 MAC.
Keychain::with_certificate_filefails on it, and the same file with the same password imports fine as soon as-f pkcs12is passed. Older p12s using the legacy RC2/3DES encoding import either way, so nothing changes for those.One thing worth flagging: naming the format means the import no longer accepts a bare PEM or DER certificate, which inference used to let through. Every caller in the tree passes a p12 and
ENVIRONMENT_VARIABLES.mddocuments these variables as p12, so I left it strict rather than adding a fallback, but say the word if you would rather it retried without the flag.Fixes #15843