Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALL-4863: doge getblock verbose param should be boolean #1066

Closed
wants to merge 1 commit into from

Conversation

rostislavjadavan
Copy link
Contributor

Description

Doge getBlock method has different type of verbosity param then other UTXO based chains.
See:
https://github.com/dogecoin/dogecoin/blob/3a29ba6d497cd1d0a32ecb039da0d35ea43c9c85/src/rpc/blockchain.cpp#L741

Fixes # (issue)

  • ALL-4863

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@Hathoriel Hathoriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update package json and change log.

Copy link
Member

@Hathoriel Hathoriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to change

 async getBlock(hashOrHeight: string, verbose: 0 | 1 | 2 = 1): Promise<JsonRpcResponse<any>> {
    return this.rpcCall<JsonRpcResponse<any>>('getblock', [hashOrHeight, verbose])
  }

in AbstractUtxoRpc.ts.
You just changed the interface, but not the params of the implementation.

@rostislavjadavan rostislavjadavan deleted the bugfix/ALL-4863-doge-getblock branch February 20, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants