ALL-5473 - Fix SOL duplicate txID (#1074)

tatumio · Mar 5, 2024 · d562121 · d562121
1 parent 1ea5099
commit d562121
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "tatumio",
-  "version": "2.2.53",
+  "version": "2.2.54",
   "license": "MIT",
   "repository": "https://github.com/tatumio/tatum-js",
   "scripts": {

diff --git a/packages/blockchain/solana/src/lib/__tests__/solana.tx.spec.ts b/packages/blockchain/solana/src/lib/__tests__/solana.tx.spec.ts
@@ -6,7 +6,7 @@ import { FEE_PAYER } from '../services/solana.utils'
 
 jest.setTimeout(99999)
 
-describe.skip('SolanaSDK - tx', () => {
+describe('SolanaSDK - tx', () => {
   const sdk = TatumSolanaSDK({
     apiKey: REPLACE_ME_WITH_TATUM_API_KEY,
     provider: 'https://api.devnet.solana.com',
@@ -366,7 +366,7 @@ describe.skip('SolanaSDK - tx', () => {
     })
   })
 
-  describe('External signing', () => {
+  describe.skip('External signing', () => {
     it('should send SPL token with fee payer', async () => {
       const tx = await sdk.spl.send.transferSignedTransaction(
         {

diff --git a/packages/blockchain/solana/src/lib/services/solana.tx.ts b/packages/blockchain/solana/src/lib/services/solana.tx.ts
@@ -1,4 +1,10 @@
-import { LAMPORTS_PER_SOL, PublicKey, SystemProgram, Transaction } from '@solana/web3.js'
+import {
+  LAMPORTS_PER_SOL,
+  PublicKey,
+  sendAndConfirmTransaction,
+  SystemProgram,
+  Transaction,
+} from '@solana/web3.js'
 import { SolanaService, TransferSolanaBlockchainKMS } from '@tatumio/api-client'
 import { SolanaWeb3 } from './solana.web3'
 import BigNumber from 'bignumber.js'
@@ -51,7 +57,7 @@ const transferSignedTransaction = async (
   }
 
   return {
-    txId: await connection.sendTransaction(transaction, signers),
+    txId: await sendAndConfirmTransaction(connection, transaction, signers),
   }
 }