fixing pylinting with a more readable code

jobs/create.py

@@ -9,17 +9,18 @@
 from jobs.sentiment import get_sentiment
 
 load_dotenv()
+env = {
+    'local_only': os.getenv('LOCAL', 'False').lower() \
+        in ('true', '1', 't', 'on', 'ok'),
+    'visibility': os.getenv('VISIBILITY', 'public').lower(),
+    'frequency': int(os.getenv('EVERY_MINUTES', '60')),
+    'quantity': int(os.getenv('HOW_MANY', '1'))
+}
 
 def publish_note():
     """ Takes the latest published news and posts a note """
-    local_only = os.getenv('LOCAL', 'False').lower() \
-        in ('true', '1', 't', 'on', 'ok')
-    visibility = os.getenv('VISIBILITY', 'public').lower()
-    frequency = int(os.getenv('EVERY_MINUTES', '60'))
-    quantity = int(os.getenv('HOW_MANY', '1'))
-
-    if quantity >= frequency//2:
-        quantity = frequency//2-1
+    if env['quantity'] >= env['frequency']//2:
+        env['quantity'] = env['frequency']//2-1
 
     db = sqlite3.connect('feed-bot.sqlite')
     c = db.cursor()
@@ -29,21 +30,25 @@ def publish_note():
         SELECT * FROM news 
         WHERE notedAt IS NULL OR notedAt = ''
         ORDER BY publishedAt DESC LIMIT ?
-    ''', str(quantity))
+    ''', str(env['quantity']))
     data = c.fetchall()
 
     if data is not None:
         for d in data:
-            sentiment = get_sentiment(d[4] + d[5])
-            text = "\n<b>" + d[4] + "</b>\n" + d[5] + " <i>(" +d[1] + ")</i>\n\n" + d[3]
-            cw = None if sentiment >= 0 else ":nsfw: News article flagged CW"
+            note_params = {
+                'sentiment': get_sentiment(d[4] + d[5]),
+                'text': "\n<b>" + d[4] + "</b>\n" + d[5] + " <i>(" +d[1] + ")</i>\n\n" + d[3],
+                'cw': None
+            }
+            if note_params['sentiment'] < 0: 
+                note_params['cw'] = ":nsfw: News article flagged CW"
             time.sleep(2)
             try:
                 api = mk.notes_create(
-                    text=text,
-                    visibility=visibility,
-                    local_only=local_only,
-                    cw=cw
+                    text=note_params['text'],
+                    visibility=env['visibility'],
+                    local_only=env['local_only'],
+                    cw=note_params['cw']
                 )
                 n_id = api['createdNote']['id']
                 n_at = int(datetime.strptime(
@@ -52,8 +57,8 @@ def publish_note():
 
                 c.execute('''
                     UPDATE news SET sentiment = ?, noteId = ?, notedAt = ? WHERE id = ?
-                ''', (sentiment, n_id, n_at, d[0]))
+                ''', (note_params['sentiment'], n_id, n_at, d[0]))
                 db.commit()
             except MisskeyAPIException as e:
                 print(f"MK API error: {e}")
-        db.close()
+    db.close()

jobs/delete.py

@@ -28,10 +28,10 @@ def purge():
             time.sleep(2)
             try:
                 denoted = mk.notes_delete(note_id=n[0])
+                if denoted is not None:
+                    c.execute('DELETE FROM news WHERE noteId = ?', (n[0],))
             except MisskeyAPIException:
                 pass
-            if denoted is not None:
-                c.execute('DELETE FROM news WHERE noteId = ?', (n[0],))
     else:
         print('No notes to delete.')