This repository was archived by the owner on Nov 1, 2022. It is now read-only.
Open
Conversation
koutoftimer
suggested changes
Sep 8, 2021
koutoftimer
left a comment
koutoftimer
left a comment
There was a problem hiding this comment.
Can reach negative values (decreasing score) for killing enemies, which is not intended behavior.
| ## as there will be no mob_elements left out | ||
| for hit in hits: | ||
| score += 50 - hit.radius ## give different scores for hitting big and small metoers | ||
| score += 50 - hit.radius -int(score/3000 ) ## give different scores for hitting big and small metoers |
There was a problem hiding this comment.
Can it be that an expression 50 - hit.radius -int(score/3000 ) gives a negative value?
Plus: is it unconvinient to add whitespace inside brackets as well as no space around minus sign.
Comment on lines
+508
to
+509
| for m in range(int(1+score/3000)): | ||
| newmob() ## spawn a new mob |
There was a problem hiding this comment.
So, you have increased number of mobs at 100% of initial value every 3000 score. Maybe it will be better to make more smooth switch? 100% at a time is a lot, it can like "no mobs" and "a lot of mobs" transition, because of x2, while reaching every new barrier will give us +33%, +25% or total amount of mobs and it may be unnoticeable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.