Locate using lsp queries #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voodoos
requested changes
Jan 6, 2025
There was a problem hiding this comment.
Looks good !
I have two remarks:
- Go to type-declaration is an actual user action, not a fallback for when we fail to find a definition
- Your mix and matching
findandlocatein the various utility functions. We should settle on one verb! I guesslocateis Merlin's terminology whilefindis LSP's. I will let you chose the one you prefer :-)
Co-authored-by: Ulysse <[email protected]>
voodoos
approved these changes
Jan 6, 2025
Co-authored-by: Ulysse <[email protected]>
xvw
force-pushed
the
locate-using-lsp-queries
branch
from
75a40c6 to
441b617
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
find/locateis by default backed byxref, which is very limited in terms of customization (for example, concerning definition or declaration control). This PR reimplements the Locate command by directly invoking LSP requests.