Initial work to add support for Cohere Provider #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would rather do this through a fetch proxy or similar middleware. |
|
Eg vercel sdk decided on some common format and then have translators to/from it https://github.com/vercel/ai/blob/main/packages/cohere/src/convert-to-cohere-chat-prompt.ts#L7 I think doing this to/from openai would be a more reasonable option. |
tarasglek
reviewed
Nov 19, 2024
| @@ -183,7 +183,8 @@ ${func.name}(${JSON.stringify(data, null, 2)})\n\`\`\`\n`; | |||
| functionName: string, | |||
| functionArgs: string | |||
| ) => { | |||
| if (content.length > 0) { | |||
| // TODO: need to deal with Cohere returning different data for tokens... | |||
|
excited to get cohere support, i love their web search tool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to implement #610, and was able to get to the point of sending a chat completion. However, Cohere's API is different enough from OpenAI that I can't use the OpenAI client.
To properly fix this, I think we need to extend Chat Providers with a way to override the client and API calls that get made with it. This would allow us to use Anthropic directly too, and others that differ significantly.
Or we could switch to a wrapper client like https://sdk.vercel.ai/docs/introduction to help smooth out the differences.