Issue 736 upgrade iframe version #741
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humphd
requested changes
Nov 18, 2024
|
Your stuff looks good, but I'm not happy with all this console spam: 
Is there a way to silence all this? If not, I think we should look for an alternative, or stick with what we have. |
|
Hey can you talk about how to reproduce these logs? because I dont see these logs on my console. Regardless, even I am getting the license log, I dont think we can get rid of that. |
|
I don't want this spamware in our app. Can you research another option? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue #736, where the objective was to upgrade the
iframe-resizer-reactpackage to the current latest version.After a bit of research I found out that the new version was now called
@iframe-resizer/react, and the child script that goes into the HTML content of the iframe was updated as well. Therefore the changes are as follows:/public/js/iframeResizer.contentWindow.min.jsto the current latest child script. (this script goes into the HTML content in the iframe),HtmlPreview.tsxfile to use the correct package, and use the open source license.I was able to test this iframe on google chrome and safari on mac, and it worked perfectly.
Please let me know if any more changes are needed!!l.