instance: total memory metric #519
Conversation
patapenka-alexey
force-pushed
the
patapenka-alexey/tntp-4363-instance-memory
branch
from
4cd4c5c to
c0dc385
Compare
patapenka-alexey
force-pushed
the
patapenka-alexey/tntp-4363-instance-memory
branch
from
c0dc385 to
b04387a
Compare
patapenka-alexey
requested review from
DifferentialOrange
and removed request for
oleg-jukovec
doc/monitoring/metrics_reference.rst
Outdated
| :widths: 25 75 | ||
| :header-rows: 0 | ||
|
|
||
| * - ``tnt_instance_memory`` |
There was a problem hiding this comment.
In the documentation, each section is enabled/disabled separately. If you introduce instance section, its metrics should be in a separate section.
There was a problem hiding this comment.
This part also should be updated
https://github.com/tarantool/metrics/blob/master/doc/monitoring/api_reference.rst#metrics-functions
metrics/tarantool/instance.lua
Outdated
| --[[vinyl]] | ||
| local vinyl_stat = box.stat.vinyl() | ||
| if vinyl_stat ~= nil then | ||
| memory_stat = memory_stat + vinyl_stat.memory.tuple_cache |
There was a problem hiding this comment.
It seems that box.info.memory().cache and box.stat.vinyl().tuple_cache are the same, so they're counted twice
cache– the number of bytes used for caching user data. The memtx storage engine does not require a cache, so in fact this is the number of bytes in the cache for the tuples stored for the vinyl storage engine.
(https://www.tarantool.io/en/doc/latest/reference/reference_lua/box_info/memory/)
The same goes for box.info.memory().data and box.info.memory().index
data– the number of bytes used for storing user data (the tuples) with the memtx engine and with level 0 of the vinyl engine, without taking memory fragmentation into account.
index– the number of bytes used for indexing user data, including memtx and vinyl memory tree extents, the vinyl page index, and the vinyl bloom filters.
patapenka-alexey
force-pushed
the
patapenka-alexey/tntp-4363-instance-memory
branch
6 times, most recently
from
ba6e1bf to
46efe82
Compare
patapenka-alexey
force-pushed
the
patapenka-alexey/tntp-4363-instance-memory
branch
5 times, most recently
from
33d1617 to
2252b87
Compare
This patch adds new `tnt_memory` metric. Closes #TNTP-4363
patapenka-alexey
force-pushed
the
patapenka-alexey/tntp-4363-instance-memory
branch
from
4ded5f2 to
9049a83
Compare
patapenka-alexey
deleted the
patapenka-alexey/tntp-4363-instance-memory
branch
Bump metric package submodule. Commits from PR[1-5] add new metric to Tarantool. 1. tarantool/metrics#519 2. tarantool/metrics#521 3. tarantool/metrics#524 4. tarantool/metrics#525 5. tarantool/metrics#527
Bump metric package submodule. Commits from PR[1-5] add new metric to Tarantool. 1. tarantool/metrics#519 2. tarantool/metrics#521 3. tarantool/metrics#524 4. tarantool/metrics#525 5. tarantool/metrics#527 @TarantoolBot document Title: Document `new system memory metrics` `'tnt_memory'`, `'tnt_memory_virt'`, `'schema_needs_upgrade'` are new metrics, introduced in metrics 1.6.0, and enabled by default.
5 participants
This patch adds new
tnt_memorymetric.Closes #TNTP-4363