api: TRANSFER_IN_PROGRESS error shoud be retryable #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_75
branch
from
42c9235 to
461aaec
Compare
oleg-jukovec
requested changes
Aug 25, 2025
oleg-jukovec
requested changes
Aug 25, 2025
There was a problem hiding this comment.
Since the library has moved to another team, the rules for formatting commits and changelog have changed a bit. Please update the commit message to something like this.
api: TRANSFER_IN_PROGRESS error shoud be retryable
Lua vshard router changed its behavior [1], we should conform.
1. https://github.com/tarantool/vshard/issues/548
Closes #75
and update the changelog entry.
RunsFor
suggested changes
Aug 26, 2025
Lua vshard router changed its behavior [1], we should conform. 1. tarantool/vshard#548 Closes tarantool#75
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_75
branch
from
96b87fe to
7811eed
Compare
nurzhan-saktaganov
changed the title
|
@oleg-jukovec I have updated the commit message and applied your suggestion about changelog entry. @RunsFor Unfortunately, the current testing framework doesn't allow to write tests for such complex scenario 😞 I have updated the PR description above and added this information. |
oleg-jukovec
approved these changes
Sep 11, 2025
palage4a
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lua vshard router changed its behavior [1], we should conform.
TRANSFER_IN_PROGRESSerror shoud be retryable vshard#548Closes #75
Unfortunately, no new tests are provided due to limitations of the current testing module. To provide tests for such complex cases, the current testing framework should be extended significantly.
I didn't forget about (remove if it is not applicable):
Related issues:
Resolve #75