Skip to content

Add recommendations on non-idempotent operations to vshard docs #5252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: latest
Choose a base branch
from
Open

Add recommendations on non-idempotent operations to vshard docs #5252

wants to merge 4 commits into from
+135 −0

Conversation

@xuniq
Copy link
Contributor

@xuniq xuniq commented Jul 16, 2025 •
edited
Loading

@github-actions github-actions bot temporarily deployed to branch-5242-deduplication July 16, 2025 10:04 Destroyed
@xuniq xuniq force-pushed the 5242-deduplication branch from 9db369a to d0c7e23 Compare July 17, 2025 10:02
@github-actions github-actions bot temporarily deployed to branch-5242-deduplication July 17, 2025 10:04 Destroyed
@xuniq xuniq force-pushed the 5242-deduplication branch from d0c7e23 to e601387 Compare July 17, 2025 10:40
@github-actions github-actions bot temporarily deployed to branch-5242-deduplication July 17, 2025 10:41 Destroyed
@xuniq xuniq force-pushed the 5242-deduplication branch from e601387 to acd7589 Compare July 17, 2025 10:47
@github-actions github-actions bot temporarily deployed to branch-5242-deduplication July 17, 2025 10:49 Destroyed
@xuniq xuniq marked this pull request as ready for review July 18, 2025 10:02
@xuniq xuniq force-pushed the 5242-deduplication branch from acd7589 to d3b7c4a Compare July 18, 2025 10:03
@github-actions github-actions bot temporarily deployed to branch-5242-deduplication July 18, 2025 10:05 Destroyed
@xuniq xuniq force-pushed the 5242-deduplication branch from d3b7c4a to 8269db6 Compare July 21, 2025 10:27
@xuniq xuniq requested a review from sergepetrenko July 21, 2025 10:27
@github-actions github-actions bot temporarily deployed to branch-5242-deduplication July 21, 2025 10:28 Destroyed
@sergepetrenko sergepetrenko self-assigned this Jul 22, 2025
sergepetrenko
sergepetrenko reviewed Jul 22, 2025
View reviewed changes
Copy link
Contributor

@sergepetrenko sergepetrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed description!

Please, consider my comments below. I also suggest asking @Totktonada to take a look at this doc.

@sergepetrenko sergepetrenko assigned xuniq and unassigned sergepetrenko Jul 22, 2025
@xuniq xuniq requested a review from Totktonada July 25, 2025 09:29
@xuniq xuniq force-pushed the 5242-deduplication branch from 8269db6 to 85d5ad4 Compare October 10, 2025 10:38
@xuniq xuniq removed the request for review from Totktonada October 10, 2025 10:38
@github-actions github-actions bot temporarily deployed to branch-5242-deduplication October 10, 2025 10:39 Destroyed
@xuniq xuniq force-pushed the 5242-deduplication branch from 85d5ad4 to 9131155 Compare October 10, 2025 11:03
@github-actions github-actions bot temporarily deployed to branch-5242-deduplication October 10, 2025 11:05 Destroyed
@xuniq xuniq assigned sergepetrenko and unassigned xuniq Oct 14, 2025
@xuniq xuniq requested a review from sergepetrenko October 14, 2025 10:08
@github-actions github-actions bot temporarily deployed to branch-5242-deduplication October 16, 2025 08:52 Destroyed
@github-actions github-actions bot temporarily deployed to branch-5242-deduplication October 16, 2025 09:13 Destroyed
@xuniq
Copy link
Contributor Author

xuniq commented Oct 21, 2025

@sergepetrenko review this PR please

sergepetrenko
sergepetrenko approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@sergepetrenko sergepetrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed description!

LGTM. Only one comment left.

@sergepetrenko sergepetrenko assigned xuniq and unassigned sergepetrenko Oct 24, 2025
@xuniq xuniq force-pushed the 5242-deduplication branch from 636af76 to 3173f40 Compare October 24, 2025 13:35
@xuniq xuniq requested a review from lenkis October 24, 2025 13:36
lenkis
lenkis approved these changes Oct 27, 2025
View reviewed changes
doc/platform/sharding/vshard_admin.rst
Currently, deduplication can be only implemented by the user in the application code.

For example, when you add a new tuple to a space, you can use a unique insert ID to check the request.
In the example below within a single transaction:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In the example below within a single transaction:
In the example below, within a single transaction:

doc/platform/sharding/vshard_admin.rst
In the example below, within a single transaction:

1. It is checked whether the ``deduplication_key`` request ID exists in the ``deduplication`` space.
2. If there is no such ID, The ID is added to the deduplication space.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. If there is no such ID, The ID is added to the deduplication space.
2. If there is no such ID, the ID is added to the deduplication space.

doc/reference/reference_rock/vshard/vshard_router.rst
shard with the specified ``bucket_id``, it will retry until the timeout is reached.

* ``request_timeout`` (since ``vshard`` 0.1.28) — timeout in seconds that serves as a protection against hung replicas.
The parameter is used in the read requests only (``mode=read``).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The parameter is used in the read requests only (``mode=read``).
The parameter is used in read requests only (``mode=read``).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lenkis lenkis lenkis approved these changes

@sergepetrenko sergepetrenko sergepetrenko approved these changes

Assignees

@xuniq xuniq

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add the request_timeout option to vshard.router.call{ro/re/bro/bre} Add recommendations on non-idempotent operations to vshard docs

3 participants

@xuniq @lenkis @sergepetrenko