etcd-client: linearizable reads + round-robin endpoints fix stale leader map #2345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Satbek
changed the title
Satbek
changed the title
a1div0
approved these changes
Jul 11, 2025
vakhov
approved these changes
Jul 11, 2025
Co-authored-by: Alex Vakhov <[email protected]>
Co-authored-by: Alex Vakhov <[email protected]>
olegrok
approved these changes
Jul 11, 2025
Co-authored-by: Oleg Babin <[email protected]>
Co-authored-by: Oleg Babin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for TNT-1357.
Linearizable reads by default
All ordinary reads to etcd (no wait) are now sent with quorum=true, guaranteeing the value comes from a majority node or fails fast.
Strict round-robin over endpoints
Every request (reads, writes and long-polls) advances the internal cursor and is issued to the next endpoint in the list.
A single request can therefore no longer monopolise the same minority node.
Long-polls (wait=true) unchanged except for rotation
quorum=true is not added to wait requests (etcd rejects that combination).
They still benefit from the new round-robin cursor: when the current long-poll completes, the next one goes to a different endpoint, ensuring we eventually reach a majority node.
Close #2342