add "connection_fetch_schema" to vshard config #2337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Satbek
requested changes
Jun 20, 2025
There was a problem hiding this comment.
Thanks for the patch!
I have one minor comment regarding vshard_consts vs vars.
Also there are integration tests in test/integration/multisharding_one_test.lua and test/integration/multisharding_one_test.lua
Could you please add a check for this option in those tests as well?
This option was recently introduced. This patch allows to pass it into vshard-router config.
olegrok
force-pushed
the
add-connection_fetch_schema
branch
from
ee9c46f to
314e9ed
Compare
Done |
a1div0
approved these changes
Jun 20, 2025
Satbek
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option was recently introduced. This patch allows to pass it into vshard-router config.
Closes #2335