Skip to content

doc ci #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

doc ci #226

wants to merge 1 commit into from

Conversation

salman01zp
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes #225

@dutterbutter
Copy link
Contributor

dutterbutter commented Jun 14, 2022

@salman01zp To ensure the docs publication works, I would suggest commenting out this line in .github/workflows/publish-docs.yml:

    if: github.event_name == 'push' && github.event.ref == 'refs/heads/main'

Commenting this out, will run the docs job on a pull request. If it succeeds to publish, then uncomment to ensure we skip this job until merge into main.

I will close #205 in favour of this PR.

@dutterbutter dutterbutter added the wip 🚧 Work in-progress label Jun 14, 2022
@dutterbutter
Copy link
Contributor

Closing in favour of #232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip 🚧 Work in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Fix Doc CI
2 participants