Fix dists #736
Merged
Fix dists #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's all working. Please test. |
tanghaibao
approved these changes
Jan 4, 2025
There was a problem hiding this comment.
Thank you @Adamtaranto!
Comparing the dist before the refactoring (1.4.24) and after the refactor (1.4.25..):
- It seems that the new source tarball ships with
.so(compiled on my mac), where it should be source only - The wheel contains the
.so, which is expected, however it is not named accordingly.
So I don't think these dist would work on linux, since the shipped so doesn't work on them (hence I can't release it to PyPI yet). I'll try find a linux to test.
Merging this for now since the fix is now working on mac at least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in Progress. Do not merge yet.
Wheel and Tarball produced by
hatch buildwere not pip installable.wheel
tarball