-
Notifications
You must be signed in to change notification settings - Fork 99
Update yarn from v4.5.0 to v4.9.1 in corepack configuration #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gabebohlmann
wants to merge
2
commits into
tamagui:main
Choose a base branch
from
gabebohlmann:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Tested this again by just directly hooking Vercel up to this repo and it correctly uses yarn v4.5.0 but I still think the upgrade to yarn v4.9.1 should be made because errors occur on deployment. Error log here [15:53:16.952] Running build in Washington, D.C., USA (East) – iad1
[15:53:16.953] Build machine configuration: 2 cores, 8 GB
[15:53:16.967] Cloning github.com/gabebohlmann/starter-free-og (Branch: main, Commit: 758913b)
[15:53:16.975] Skipping build cache, deployment was triggered without cache.
[15:53:17.539] Cloning completed: 571.000ms
[15:53:18.062] Running "vercel build"
[15:53:18.903] Vercel CLI 42.2.0
[15:53:20.166] ➤ YN0000: Successfully set enableGlobalCache to false
[15:53:20.187] Installing dependencies...
[15:53:21.189] ➤ YN0000: · Yarn 4.5.0
[15:53:21.190] ➤ YN0000: ┌ Project validation
[15:53:21.191] ➤ YN0057: │ expo-app: Resolutions field will be ignored
[15:53:21.191] ➤ YN0000: └ Completed
[15:53:21.206] ➤ YN0000: ┌ Resolution step
[15:53:22.001] ➤ YN0000: └ Completed in 0s 794ms
[15:53:22.004] ➤ YN0000: ┌ Post-resolution validation
[15:53:22.005] ➤ YN0086: │ Some peer dependencies are incorrectly met by dependencies; run yarn explain peer-requirements for details.
[15:53:22.082] ➤ YN0000: └ Completed
[15:53:22.083] ➤ YN0000: ┌ Fetch step
[15:54:11.019] ➤ YN0066: │ typescript@patch:typescript@npm%3A5.8.3#optional!builtin<compat/typescript>::version=5.8.3&hash=8c6c40: Cannot apply hunk #1
[15:54:19.904] ➤ YN0000: └ Completed in 57s 821ms
[15:54:19.983] ➤ YN0000: ┌ Link step
[15:54:44.004] ➤ YN0007: │ @biomejs/biome@npm:1.9.4 must be built because it never has been before or the last one failed
[15:54:44.005] ➤ YN0007: │ esbuild@npm:0.25.0 must be built because it never has been before or the last one failed
[15:54:44.005] ➤ YN0007: │ esbuild@npm:0.21.5 must be built because it never has been before or the last one failed
[15:54:44.006] ➤ YN0007: │ esbuild@npm:0.14.47 must be built because it never has been before or the last one failed
[15:54:44.006] ➤ YN0007: │ @swc/core@npm:1.11.4 [1ed6c] must be built because it never has been before or the last one failed
[15:54:44.919] ➤ YN0007: │ starter-free@workspace:. must be built because it never has been before or the last one failed
[15:54:47.092] ➤ YN0000: │ starter-free@workspace:. STDOUT Tamagui dependencies look good ✅
[15:54:49.784] ➤ YN0000: │ starter-free@workspace:. STDOUT built @my/config in 410 ms
[15:54:51.027] ➤ YN0000: │ starter-free@workspace:. STDOUT built @my/ui in 481 ms
[15:54:51.034] ➤ YN0000: │ starter-free@workspace:. STDOUT Done in 2s 440ms
[15:54:51.058] ➤ YN0000: └ Completed in 31s 75ms
[15:54:51.245] ➤ YN0000: · Done with warnings in 1m 31s
[15:54:54.600] built @my/config in 183 ms
[15:54:55.424] built @my/ui in 281 ms
[15:54:55.439] Done in 1s 593ms
[15:54:58.182] Attention: Next.js now collects completely anonymous telemetry regarding usage.
[15:54:58.183] This information is used to shape Next.js' roadmap and prioritize features.
[15:54:58.183] You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
[15:54:58.184] https://nextjs.org/telemetry
[15:54:58.184]
[15:54:58.237] ▲ Next.js 14.2.14
[15:54:58.238] - Environments: .env
[15:54:58.239] - Experiments (use with caution):
[15:54:58.239] · scrollRestoration
[15:54:58.239]
[15:54:58.293] Creating an optimized production build ...
[15:55:00.186] No native ExponentConstants module found, are you sure the expo-constants's module is linked properly?
[15:55:00.548] [tamagui] skipped loading 4 module, see: https://tamagui.dev/docs/intro/errors#warning-001
[15:55:45.082] ⚠ Compiled with warnings
[15:55:45.082]
[15:55:45.082] ../../node_modules/react-native-web/dist/exports/render/index.js
[15:55:45.082] Attempted import error: 'hydrate' is not exported from 'react-dom' (imported as 'domLegacyHydrate').
[15:55:45.082]
[15:55:45.082] Import trace for requested module:
[15:55:45.082] ../../node_modules/react-native-web/dist/exports/render/index.js
[15:55:45.082] ../../node_modules/react-native-web/dist/index.js
[15:55:45.082] ../../packages/app/provider/NextTamaguiProvider.tsx
[15:55:45.083]
[15:55:45.083] ../../node_modules/react-native-web/dist/exports/unmountComponentAtNode/index.js
[15:55:45.083] Attempted import error: 'unmountComponentAtNode' is not exported from 'react-dom' (imported as 'unmountComponentAtNode').
[15:55:45.083]
[15:55:45.083] Import trace for requested module:
[15:55:45.083] ../../node_modules/react-native-web/dist/exports/unmountComponentAtNode/index.js
[15:55:45.083] ../../node_modules/react-native-web/dist/index.js
[15:55:45.083] ../../packages/app/provider/NextTamaguiProvider.tsx
[15:55:45.083]
[15:55:45.086] Skipping validation of types
[15:55:45.086] Linting ...
[15:55:45.493] ⨯ ESLint: Invalid Options: - Unknown options: useEslintrc, extensions - 'extensions' has been removed.
[15:55:45.496] Collecting page data ...
[15:55:46.177] Generating static pages (0/6) ...
[15:55:47.990] Generating static pages (1/6)
[15:55:47.991] Generating static pages (2/6)
[15:55:48.255] Generating static pages (4/6)
[15:55:48.331] ✓ Generating static pages (6/6)
[15:55:48.685] Finalizing page optimization ...
[15:55:48.685] Collecting build traces ...
[15:55:55.054]
[15:55:55.058] Route (app) Size First Load JS
[15:55:55.058] ┌ ○ / 11.9 kB 195 kB
[15:55:55.058] ├ ○ /_not-found 877 B 88.2 kB
[15:55:55.059] └ ƒ /user/[id] 809 B 167 kB
[15:55:55.059] + First Load JS shared by all 87.3 kB
[15:55:55.059] ├ chunks/1dd3208c-5af9e1eb36e1ba27.js 53.6 kB
[15:55:55.059] ├ chunks/528-f53b50c17ca5ccb6.js 31.7 kB
[15:55:55.059] └ other shared chunks (total) 1.98 kB
[15:55:55.059]
[15:55:55.059] Route (pages) Size First Load JS
[15:55:55.059] ┌ /_app 0 B 227 kB
[15:55:55.059] ├ ○ /pages-example 11.9 kB 257 kB
[15:55:55.059] └ ○ /pages-example-user/[id] 1.74 kB 246 kB
[15:55:55.059] + First Load JS shared by all 445 kB
[15:55:55.059] ├ chunks/framework-f41951523397ef37.js 57.6 kB
[15:55:55.059] ├ chunks/main-bd8627826fad42c2.js 33.2 kB
[15:55:55.059] ├ chunks/pages/_app-99477d4b81ae847c.js 134 kB
[15:55:55.059] ├ css/27470240c4eafd81.css 218 kB
[15:55:55.059] └ other shared chunks (total) 1.76 kB
[15:55:55.059]
[15:55:55.059] ○ (Static) prerendered as static content
[15:55:55.059] ƒ (Dynamic) server-rendered on demand
[15:55:55.059]
[15:55:55.180] Error: No Output Directory named "app" found after the Build completed. You can configure the Output Directory in your Project Settings.
[15:55:55.180] Learn More: https://vercel.link/missing-public-directory
[15:55:55.986]
[15:55:58.735] Exiting build container |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vercel is not allowing me to override the yarn version to be v4.5.0 as is necessary to deploy this repo. I set the install command to
yarn set version 4.5.0 && yarn installbut it uses v4.9.1 anyway. On Vercelyarn set version stableresolves to v4.9.1, so I updated the repo's corepack configuration to that and it works. If there is a Vercel setting I have missed to force v4.5.0 let me know. I also corrected the Vercel deployment settings in the readme. A full guide to reproducing and fixing the issue is below.Steps to reproduce
Fork main
Clone the fork locally
Attempt to deploy on Vercel without any changes
Failure: Vercel is using yarn v4.9.1, but the repo is set to use yarn v4.5.0 with its corepack config
Attempt to change Vercel deployment yarn version to 4.5.0 by setting Install command to
yarn set version 4.5.0 && yarn installRedeploy on Vercel
~/starter-free$ corepack enable~/starter-free$ yarn -vOutput: 4.5.0
~/starter-free$ yarn set version 4.9.1~/starter-free$ yarn -vOutput: 4.9.1
That updates,
.yarnrc.yml,package.json, and.yarn/releases/<version>.cjsfor the new yarn versionRun yarn install which will update yarn.lock
~/starter-free$ yarn installTest local build with
yarn buildandyarn web~/starter-free$ yarn buildPush changes to remote repo and redeploy on Vercel
Error: default Vercel build command is incorrectly set to
turbo run buildUpdate Vercel build command to the correct one from package.json
yarn web:prodand redeploySuccess!