Skip to content

Add label style options #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tasnimAlam wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add label style options #42

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31ba0a6
Add label style options
tasnimAlam Mar 26, 2020
b7fd5b0
Merge branch 'master' into feature/label-style
tasnimAlam Sep 4, 2021
a6483c6
rename label style property names
tasnimAlam Sep 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/ReactCompareImage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,13 @@ const propTypes = {
leftImageAlt: PropTypes.string,
leftImageCss: PropTypes.object, // eslint-disable-line
leftImageLabel: PropTypes.string,
leftLabelCss: PropTypes.object, // eslint-disable-line
onSliderPositionChange: PropTypes.func,
rightImage: PropTypes.string.isRequired,
rightImageAlt: PropTypes.string,
rightImageCss: PropTypes.object, // eslint-disable-line
rightImageLabel: PropTypes.string,
rightLabelCss: PropTypes.object, // eslint-disable-line
skeleton: PropTypes.element,
sliderLineColor: PropTypes.string,
sliderLineWidth: PropTypes.number,
Expand All @@ -31,10 +33,12 @@ const defaultProps = {
leftImageAlt: '',
leftImageCss: {},
leftImageLabel: null,
leftLabelCss: {},
onSliderPositionChange: () => {},
rightImageAlt: '',
rightImageCss: {},
rightImageLabel: null,
rightLabelCss: {},
skeleton: null,
sliderLineColor: '#ffffff',
sliderLineWidth: 2,
Expand All @@ -52,11 +56,13 @@ function ReactCompareImage(props) {
leftImageAlt,
leftImageCss,
leftImageLabel,
leftLabelCss,
onSliderPositionChange,
rightImage,
rightImageAlt,
rightImageCss,
rightImageLabel,
rightLabelCss,
skeleton,
sliderLineColor,
sliderLineWidth,
Expand Down Expand Up @@ -435,12 +441,16 @@ function ReactCompareImage(props) {
{/* labels */}
{leftImageLabel && (
<div style={styles.leftLabelContainer}>
<div style={styles.leftLabel}>{leftImageLabel}</div>
<div style={{ ...styles.leftLabel, ...leftLabelCss }}>
{leftImageLabel}
</div>
</div>
)}
{rightImageLabel && (
<div style={styles.rightLabelContainer}>
<div style={styles.rightLabel}>{rightImageLabel}</div>
<div style={{ ...styles.rightLabel, ...rightLabelCss }}>
{rightImageLabel}
</div>
</div>
)}
</div>
Expand Down