Skip to content

Conversation

@jaresty
Copy link
Contributor

@jaresty jaresty commented Oct 11, 2024

I am not an elixir expert but I think this covers the basics. I wasn't able to find an elixir example in community forks so I put this together on my own.

When this gets merged I will be on the lookout for feedback to improve it incrementally in subsequent changes.

@jaresty
Copy link
Contributor Author

jaresty commented Oct 11, 2024

Addresses #1512

@jaresty
Copy link
Contributor Author

jaresty commented Oct 14, 2024

Related: cursorless-dev/cursorless#1844

Copy link
Collaborator

@phillco phillco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The majority looks good to me, just need to reduce some of the bespoke spoken forms that can actually be implemented via tags

@jaresty jaresty requested a review from phillco October 18, 2024 21:39
@phillco phillco merged commit 899770b into talonhub:main Oct 18, 2024
2 checks passed
Ottaboe pushed a commit to Ottaboe/community that referenced this pull request Sep 7, 2025
I am not an elixir expert but I think this covers the basics. I wasn't
able to find an elixir example in community forks so I put this together
on my own.

When this gets merged I will be on the lookout for feedback to improve
it incrementally in subsequent changes.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Phil Cohen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants