Use viewport units for both width and height#18142
Closed
evrial wants to merge 1 commit intotailwindlabs:mainfrom
evrial:patch-1
Closed
Use viewport units for both width and height#18142evrial wants to merge 1 commit intotailwindlabs:mainfrom evrial:patch-1
evrial wants to merge 1 commit intotailwindlabs:mainfrom
evrial:patch-1
Conversation
Contributor
|
Hey! Thanks for the suggestion but this seems like an app-specific concern that we better not change in preflight (let alone the fact that this would require a major change since it probably breaks a lot of images). Feel free to do this in your own CSS if you need it: @layer base {
img {
max-width: 100vw;
max-height: 100vh;
}
} |
Author
|
Ok, yes you're right, thanks for feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
img and video should not exceed viewport size.