ts_netstack_smoltcp_core: fix client reconnect issue#239
Open
dylan-tailscale wants to merge 1 commit into
Open
ts_netstack_smoltcp_core: fix client reconnect issue#239dylan-tailscale wants to merge 1 commit into
dylan-tailscale wants to merge 1 commit into
Conversation
Fixes an issue where we were dropping a half-open socket handle that had moved back to LISTEN rather than closing the socket. This left an orphan socket in the LISTEN state in the netstack's socket set along with the intended LISTEN socket, but typically earlier in iteration order of self.socket_set than the intended socket. The result: in the axum example, packets were delivered to the orphaned LISTEN socket, smoltcp correctly handled the TCP handshake and clients could send an HTTP request, but the server would never respond, as the orphaned socket would complete the handshake and buffer the GET, but process_tcp_listen() would never accept the socket/surface the data to axum, as it had dropped the handle to the orphaned socket. Signed-off-by: Dylan Bargatze <dylan@tailscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where we were dropping a half-open socket handle that had moved back to
LISTENrather than closing the socket. This left an orphan socket in theLISTENstate in the netstack's socket set along with the intended LISTEN socket, but typically earlier in iteration order ofself.socket_setthan the intended socket. The result: in theaxumexample, packets were delivered to the orphanedLISTENsocket, smoltcp correctly handled the TCP handshake and clients could send an HTTP request, but the server would never respond, as the orphaned socket would complete the handshake and buffer the GET, butprocess_tcp_listen()would never accept the socket/surface the data to axum, as it had dropped the handle to the orphaned socket.Updates #26.