ts_packet: support yoke#235
Open
npry wants to merge 1 commit into
Open
Conversation
nrc
approved these changes
Jun 15, 2026
| } | ||
|
|
||
| // SAFETY: the underlying buf ptr is on the heap, hence stable. | ||
| unsafe impl stable_deref_trait::StableDeref for PacketMut {} |
Contributor
There was a problem hiding this comment.
I spent far too long thinking about this. I think in the end it is ok. My worry was about calling split_to which would mean calls to deref would return different pointers, but I don't see any of calling split_to without using an &mut self method. It might be worth documenting that, since if the Deref impls were changed to return a Bytes rather than a [u8], then this would be unsound
This will enable e.g. a decrypted derp packet to carry its backing `Packet` around. Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: Ic26833761832d03d372d4331723d422d6a6a6964
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for
yoketoPacket{,Mut}. This enables e.g. a decrypted derp packet to carry its backingPacketaround when published on the runtime bus (since it's!Sized).