runtime: run periodic ipv4 stuns for public ip#234
Open
npry wants to merge 1 commit into
Open
Conversation
dylan-tailscale
requested changes
Jun 12, 2026
dylan-tailscale
left a comment
dylan-tailscale
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, just one TODO to implement (correct me if I misunderstood the intent)
| type Args = Env; | ||
|
|
||
| async fn on_start(env: Self::Args, slf: ActorRef<Self>) -> Result<Self, Self::Error> { | ||
| let stun = ts_netcheck::StunProber::try_new().await.unwrap(); // TODO |
Collaborator
There was a problem hiding this comment.
Does the "TODO" mean to "replace the unwrap() with an error convert/return"?
Nothing currently consumes the messages, but this is needed for future commits re: direct connections. In the future the internals may change slightly to reuse the single UDP endpoint socket, but this should work for now. Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: Idc9dadd16a203188ab4138944fb8a6b56a6a6964
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stacked on #214
Provide an actor that runs periodic stuns to a derp server to get our public ipv4 and publishes the response on the message bus.
Nothing currently consumes the messages, but this is needed for future commits re: direct connections. In the future the internals may change slightly to reuse the single UDP endpoint socket rather than using a dedicated stun socket, but this should be fine for now.