Skip to content

feat(kit): improve performance of layout calculation#12849

Open
JonataB wants to merge 4 commits into
taiga-family:mainfrom
JonataB:improve-line-clamp-performance_#12696
Open

feat(kit): improve performance of layout calculation#12849
JonataB wants to merge 4 commits into
taiga-family:mainfrom
JonataB:improve-line-clamp-performance_#12696

Conversation

@JonataB

@JonataB JonataB commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

Improve performance

@JonataB
JonataB requested a review from a team as a code owner December 15, 2025 15:51
@JonataB
JonataB requested review from MarsiBarsi, mdlufy, nsbarsukov, vladimirpotekhin and waterplea and removed request for a team December 15, 2025 15:51
@github-actions

github-actions Bot commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

Tests completed successfully ✅

Good job 🔥

@bundlemon

bundlemon Bot commented Dec 15, 2025

Copy link
Copy Markdown

BundleMon

Unchanged files (3)
Status Path Size Limits
demo/browser/styles-(hash).css
19.35KB +10%
demo/browser/polyfills-(hash).js
12.21KB +10%
demo/browser/main-(hash).js
895B +10%

Total files change +1B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*.js
3.08MB (+182B +0.01%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov

codecov Bot commented Dec 15, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 4.65116% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.56%. Comparing base (15491f6) to head (cc39857).
⚠️ Report is 55 commits behind head on main.

Files with missing lines Patch % Lines
.../kit/components/line-clamp/line-clamp.component.ts 4.65% 37 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12849      +/-   ##
==========================================
- Coverage   59.74%   59.56%   -0.18%     
==========================================
  Files         963      959       -4     
  Lines       12320    12317       -3     
  Branches     1978     1997      +19     
==========================================
- Hits         7360     7337      -23     
+ Misses       4659     4656       -3     
- Partials      301      324      +23     
Flag Coverage Δ
summary 59.56% <4.65%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@splincode

Copy link
Copy Markdown
Member

@JonataB e2e tests failed

@JonataB

JonataB commented Dec 16, 2025

Copy link
Copy Markdown
Contributor Author

Hi @splincode, i will check. I had no time due to job tasks

@JonataB

JonataB commented Dec 18, 2025

Copy link
Copy Markdown
Contributor Author

@splincode i fixed issues but i have to review code

@splincode
splincode force-pushed the improve-line-clamp-performance_#12696 branch from c7c1737 to c43429a Compare December 18, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants