Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show stacktrace of a compiler error only in verbose mode #1375

Merged

Conversation

i582
Copy link
Contributor

@i582 i582 commented Jan 17, 2025

Issue

Closes #1360.

Checklist

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@i582 i582 added this to the v1.6.0 milestone Jan 17, 2025
@i582 i582 requested a review from a team as a code owner January 17, 2025 07:18
@anton-trunov
Copy link
Member

We also need to add some tests for this flag.
For now we have some CLI tests in CI:

- name: CLI Test | Check tact --version
, until we have some proper cram-like tests: #315.

@anton-trunov anton-trunov self-assigned this Jan 17, 2025
@anton-trunov
Copy link
Member

We also need to be able to active the verbose mode via blueprint which basically ignores tact.config.json: ton-org/blueprint#138

Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix CI for macOS and also resolve comments by @novusnota.

Although, looks like it's too hard to work with the current CLI tests since cross-platform scripts are harder even for Unix-like OSes.

@i582
Copy link
Contributor Author

i582 commented Jan 20, 2025

Let's add actual documentation, like

0 - no output
1 - current without stack trace (default)
2 - current

after we implement level 0

@anton-trunov anton-trunov merged commit 988b5e8 into main Jan 20, 2025
21 of 22 checks passed
@anton-trunov anton-trunov deleted the pmakhnev/show-compiler-error-stacktrace-only-in-verbose-mode branch January 20, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't show stacktrace from compiler after compiler error by default
3 participants