Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply skipValidation to all presets when set on parent #326

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Abdalrhman-Almarakeby
Copy link

Previously, presets ignored the parent’s skipValidation flag, requiring manual setup. This fix makes them inherit it automatically.

fixes #323.

Copy link

vercel bot commented Mar 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
t3-env ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 0:20am

Copy link

vercel bot commented Mar 28, 2025

@Abdalrhman-Almarakeby is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@OreQr
Copy link

OreQr commented Mar 29, 2025

Maybe make all customization options like this

@Abdalrhman-Almarakeby
Copy link
Author

Maybe make all customization options like this

skipValidation makes the most sense to work this way. anyone would expect it to skip validation for presets too (see #323). But at the end, it's up to the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extended configurations do not respect skipValidation
2 participants