Skip to content

Support function in timeFormat#485

Open
thienvu18 wants to merge 1 commit into
t1m0n:v3from
thienvu18:v3
Open

Support function in timeFormat#485
thienvu18 wants to merge 1 commit into
t1m0n:v3from
thienvu18:v3

Conversation

@thienvu18

Copy link
Copy Markdown

No description provided.

@vercel

vercel Bot commented Mar 7, 2022

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/t1m0n/air-datepicker/FsLUGC54s7L7CNHigfBSkUQCV9qo
✅ Preview: https://air-datepicker-git-fork-thienvu18-v3-t1m0n.vercel.app

@t1m0n

t1m0n commented May 31, 2022

Copy link
Copy Markdown
Owner

@thienvu18 Thank you for your PR! I'm sorry for the late answer.

I've looked through your changes, and it seems to me that it may be confusing to have timeFormat as function only in onlyTimepicker mode.

I think that, in onlyTimepicker mode user could use dateFormat as function to format time, as it would be in normal mode with date selection. In such case there would be some consistency in behaviour as dateFormat function fully shifts responsibility in formatting date\time to user in both modes. And it takes only one line of code to change).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants