Fix memory leaks in widget/window lifecycle #117
Merged
+26
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds proper destroy event handling throughout the widget hierarchy to fix memory leaks: - box: Propagate destroy events to all child widgets before destruction - widget: Add TwinEventDestroy case to base widget dispatch - label: Free dynamically allocated label text on destroy - window: Invoke destroy callbacks to allow proper resource cleanup - pixmap: Initialize window field to prevent undefined behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds proper destroy event handling throughout the widget hierarchy to fix memory leaks:
Summary by Bito
This pull request addresses memory leaks by implementing proper destroy event handling in the widget and window lifecycle. Key changes include propagating destroy events to child widgets, freeing dynamically allocated resources, and initializing fields to prevent undefined behavior.