Add configurable pixmap caching with LRU eviction #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements transparent pixmap caching to improve performance by reusing frequently allocated pixmaps with identical format and dimensions. Cache features: - Automatic operation in twin_pixmap_create/destroy - LRU eviction policy respecting reference counts to prevent use-after-free - Hash-based lookup with collision handling via eviction Configuration options (added to Features menu): - CONFIG_PIXMAP_CACHE: Enable/disable caching (default: y) - CONFIG_PIXMAP_CACHE_SIZE: Entry count 4-32 (default: 8) - CONFIG_PIXMAP_CACHE_MAX_KB: Memory limit 16-512KB (default: 64KB)
weihsinyeh
reviewed
Aug 3, 2025
| twin_coord_t height) | ||
| { | ||
| twin_coord_t stride = twin_bytes_per_pixel(format) * width; | ||
| if (stride % 4 != 0) |
There was a problem hiding this comment.
Can use IS_ALIGNED and ALIGN_UP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements transparent pixmap caching to improve performance by reusing frequently allocated pixmaps with identical format and dimensions.
Cache features:
Configuration options (added to Features menu):
Summary by Bito
This pull request introduces a configurable pixmap caching feature to enhance performance by reusing frequently allocated pixmaps. It includes options for enabling caching, setting maximum cached entries, and defining memory limits, along with an LRU eviction policy to manage cache effectively and prevent memory issues.