Parse GTID ranges on proxysql_mysqlbinlog update messages.

[proton-lisandro-pin]

Following up on #5224, this PR adds full support for ranges in proxysql_mysqlbinlog update messages, while also improving efficiency when dealing with GTID gaps for any given UUID.

Single GTID updates are transparently supported, so older proxysql_mysqlbinlog version will continue to work with newer ProxySQL releases.

See sysown/proxysql_mysqlbinlog#33 for details.

Once this change is merged, i'll upload the last PR to batch GTID updates as ranges in proxysql_mysqlbinlog.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello @proton-lisandro-pin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances ProxySQL's GTID handling by adding support for GTID ranges in proxysql_mysqlbinlog update messages. This improves efficiency and maintains backward compatibility with older versions.

Highlights

• GTID Range Support: This PR introduces full support for GTID ranges in proxysql_mysqlbinlog update messages, enhancing compatibility and efficiency.
• Improved Efficiency: The changes improve efficiency when dealing with GTID gaps for any given UUID.
• Backward Compatibility: Single GTID updates are transparently supported, ensuring older proxysql_mysqlbinlog versions remain compatible with newer ProxySQL releases.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• GTID Support
  • Added support for GTID ranges in proxysql_mysqlbinlog update messages
  • Improved efficiency in handling GTID gaps
  • Maintained backward compatibility with older proxysql_mysqlbinlog versions

Activity

• The PR addresses issue Create a global variable that store current time #33 in the proxysql_mysqlbinlog repository.
• It follows up on PR refactor: Extract GTID interval logic into Gtid_Interval class #5224 in the ProxySQL repository.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a significant and valuable refactoring of the GTID handling logic. Encapsulating GTID sets and UUID:GTID pairs into their own classes (Gtid_Set, Uuid_Gtid) greatly improves code organization, clarity, and maintainability. The rest of the codebase is correctly updated to use these new abstractions. My review focuses on a few areas where further improvements can be made, including fixing a potential parsing bug, enhancing performance, and adhering to modern C++ best practices.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud