refactor: Extract GTID interval logic into Gtid_Interval class

[proton-lisandro-pin]

Initial work to support ranged GTID updates from proxysql_mysqlbinlog.

This PR reworks gtid_interval_t so GTID intervals can be compared/merged, and modifies the logic to add new GTIDs to gtid_set_t so it understand range updates. Notably, it will automatically de-dupe and compact overlapping ranges,
when possible.

A PR to properly parse ranges on I1= and I2= GTID update messages will follow; until then, this PR changes
no functionality within ProxySQL.

See sysown/proxysql_mysqlbinlog#33 for details.

[gemini-code-assist]

Summary of Changes

Hello @proton-lisandro-pin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces foundational changes to ProxySQL's GTID management system, specifically to enable support for ranged GTID updates. It redefines how GTID intervals are represented and manipulated internally, moving from basic pairs to a more robust Gtid_Interval class with built-in logic for merging and comparison. The core addGtid function has been revamped to intelligently handle these new interval objects, ensuring that GTID sets can correctly incorporate and consolidate ranges. This work is a prerequisite for an upcoming feature that will parse and apply ranged GTID messages from proxysql_mysqlbinlog.

Highlights

• GTID Interval Rework: The gtid_interval_t type has been refactored from a simple std::pair to a dedicated Gtid_Interval class, providing methods for comparison, merging, and string representation.
• Enhanced GTID Set Logic: The gtid_set_t now supports ranged GTID updates, with the addGtid function being significantly updated to handle the insertion and merging of Gtid_Interval objects, including sorting and consolidating overlapping ranges.
• New Source File: A new source file, proxysql_gtid.cpp, has been added to encapsulate the implementation of the Gtid_Interval class.
• No Immediate Functional Change: This PR lays the groundwork for future ranged GTID parsing, and as such, introduces no immediate functional changes to ProxySQL's behavior regarding GTID updates, as proper parsing will follow in a subsequent PR.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[proton-lisandro-pin]

Question: none of the files in lib\ appears to have unit tests defined 😕

I'll be happy to add tests for proxysql_gtid.cpp if you point me to where you'd prefer these - maybe under test\lib?

[gemini-code-assist]

Code Review

This pull request introduces significant changes to support ranged GTID updates by refactoring gtid_interval_t from a std::pair into a dedicated Gtid_Interval class and reworking the addGtid logic. The changes are well-structured and lay a good foundation for parsing GTID ranges. My review focuses on improving the C++ implementation of the new Gtid_Interval class and the associated functions, with suggestions for enhancing const correctness, readability, and adherence to C++ best practices. These improvements will make the new code more robust and easier to maintain.

[wazir-ahmed]

Looks good overall. Just a few minor comments to address.

[wazir-ahmed]

@proton-lisandro-pin please resolve the conflicts.

[proton-lisandro-pin]

@proton-lisandro-pin please resolve the conflicts.

Sorry, i didn't realize we changed the destination branch 🤦 Change is now rebased.

[wazir-ahmed]

@proton-lisandro-pin I have added documentation for unit tests here. You can add the unit test for addGtidInterval following this guide.

[proton-lisandro-pin]

@proton-lisandro-pin I have added documentation for unit tests here. You can add the unit test for addGtidInterval following this guide.

Done, PTAL.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud