Repository navigation
馃尡 Alias the latest CAPH API version as infrav1 - #2317
Draft
abdullah599 wants to merge 1 commit into
Draft
abdullah599 wants to merge 1 commit into
abdullah599 wants to merge 1 commit into
Conversation
github-actions
Bot
added
size/XXL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adopts the Cluster API import alias convention for the CAPH API packages. Every hand-written import of
api/v1beta2now uses the aliasinfrav1, and every import ofapi/v1beta1usesinfrav1beta1. This way the latest version keeps the same short alias when we move to a new API version, the same asclusterv1in Cluster API. A newimportasrule in.golangci.yamlmakes the linter enforce both aliases.Which issue(s) this PR fixes:
Fixes #2092
Special notes for your reviewer:
None.
TODOs: