Repository navigation
Conversation
github-actions
Bot
added
size/XL
abdullah599
reviewed
Oct 5, 2026
abdullah599
left a comment
abdullah599
left a comment
Contributor
There was a problem hiding this comment.
PR #2298 added CustomProvisioner.Swraid on main with // Swraid defines ..., so that one needs the same fix after a rebase. Otherwise only small things, LGTM :)
abdullah599
reviewed
Oct 6, 2026
abdullah599
reviewed
Oct 9, 2026
abdullah599
left a comment
abdullah599
left a comment
Contributor
There was a problem hiding this comment.
thanks, only the new fields from main are left else LGTM :)
abdullah599
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
api/v1beta2types were copied fromapi/v1beta1, so most field doc comments still started with the capitalized Go field name (e.g.// Host is the hostname…). The Cluster API v1beta2 convention is to start a field comment with the lowercase JSON name (// host is the hostname…), because the comment becomes the field description in the generated CRD.This PR rewrites the first word of each such comment to the field's JSON name (about 150 comments across 12 files in
api/v1beta2) and regenerates the CRDs inconfig/crd/bases. Comments that started with a different word (e.g.controlPlaneRegions,hetznerSecretRef,hcloud, theStorageandNICfields, and themetadata/statusfields of the template types) were fixed by hand.Which issue(s) this PR fixes:
Fixes #2061