Skip to content

feat: add filters to getAnnotations to improve valpal #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add filters to getAnnotations to improve valpal #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions sypht/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,9 @@ def get_annotations(
specification=None,
from_date=None,
to_date=None,
last_updated_from=None,
last_updated_to=None,
state=None,
endpoint=None,
rec_limit=None,
company_id=None,
Expand All @@ -453,6 +456,9 @@ def get_annotations(
specification=specification,
from_date=from_date,
to_date=to_date,
last_updated_from=last_updated_from,
last_updated_to=last_updated_to,
state=state,
endpoint=endpoint,
company_id=company_id,
):
Expand All @@ -467,6 +473,9 @@ def _get_annotations(
specification=None,
from_date=None,
to_date=None,
last_updated_from=None,
last_updated_to=None,
state=None,
endpoint=None,
company_id=None,
offset=0,
Expand All @@ -485,6 +494,12 @@ def _get_annotations(
filters.append("fromDate=" + from_date)
if to_date is not None:
filters.append("toDate=" + to_date)
if last_updated_from is not None:
filters.append("lastUpdatedFrom=" + last_updated_from)
if last_updated_to is not None:
filters.append("lastUpdatedTo=" + last_updated_to)
if state is not None:
filters.append("state=" + state)
if company_id is not None:
filters.append("companyId=" + company_id)

Expand Down
Loading