Updating images and fonts to use Webpack 5 Asset modules #883
Conversation
A version betweenb 5.1 and 5.2 fixed a bug related to asset modules and the key in manifest.json
| * The expectedFiles can contain a [hash:8] syntax in case | ||
| * the file is versioned - e.g. main.[hash:8].js, which would | ||
| * match a real file like main.abcd1234.js. |
| this.useFontsLoader = true; | ||
| this.imageRuleOptions = { | ||
| type: 'asset', | ||
| maxSize: null, |
There was a problem hiding this comment.
I'm wondering if we shouldn't override the default value for maxSize.
Based on the documentation everything under 8kb will be inlined... which isn't necessarily a bad thing but it will probably confuse some people/break things (for instance if someone used to import images in order to trigger a copy).
There was a problem hiding this comment.
which isn't necessarily a bad thing but it will probably confuse some people/break things
I think this will also cause some confusion. On the other hand, if you have:
import image from './images.foo.png';
img.src = image;I think this will work regardless of whether it was inlined or copied. Unless we defaulted this to 0 (or used asset/resource instead of assets by default), this will surprise people.
So, I'm conflicted: on the one hand, the inlining of 8kb and lower is probably better for performance... but will cause more confusion.
There was a problem hiding this comment.
I'm going to go the "more conservative" route and use asset/resource by default
This will help avoid confusion because images won't be inlined by default.
This is one more big piece for proper Webpack 5 support - see #880
This also updates the CHANGELOG both for this PR and for the original in #645
And, this adds a new assertion method that helps check directory contents in functional.js in a way that is more resilient to hash changes.
For the most part... this just worked! See the CHANGELOG. Because this will release on 1.0, I have decided to remove a few methods instead of deprecating them ).
Cheers!