Skip to content

[Map] Add options minZoom and maxZoom #2896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Jul 7, 2025

Q A
Bug fix? no
New feature? yes
Docs? yes
Issues Fix #...
License MIT

Replace #2520, and added @nina-alin as co-author since she started the feature.

Copy link
Contributor

github-actions bot commented Jul 7, 2025

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
Please review the changes and make sure they are expected.

FileBefore (Size / Gzip)After (Size / Gzip)
Map
abstract_map_controller.d.ts 7.45 kB / 1.41 kB 7.78 kB+4% 📈 / 1.45 kB+3% 📈
abstract_map_controller.js 5.47 kB / 1.38 kB 5.65 kB+3% 📈 / 1.42 kB+2% 📈
Map (Bridge Google)
map_controller.d.ts 3.36 kB / 876 B 3.43 kB+2% 📈 / 885 B+1% 📈
map_controller.js 14.22 kB / 3.04 kB 14.8 kB+4% 📈 / 3.14 kB+3% 📈
Map (Bridge Leaflet)
map_controller.d.ts 2.91 kB / 806 B 2.98 kB+2% 📈 / 817 B+1% 📈
map_controller.js 13.36 kB / 3.22 kB 14 kB+5% 📈 / 3.33 kB+3% 📈

@Kocal Kocal requested review from kbond and smnandre July 7, 2025 07:06
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool? Test failures unrelated?

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Jul 7, 2025
@Kocal
Copy link
Member Author

Kocal commented Jul 7, 2025

Yes they are unrelated, we still have to fix the Windows CI due to failing tests for LiveComponent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature Map Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants